Skip to content

[TypeDeclaration] Handle crash on object shape on ArrayShapeFromConstantArrayReturnRector#4323

Merged
samsonasik merged 4 commits intomainfrom
add-object-shape
Jun 23, 2023
Merged

[TypeDeclaration] Handle crash on object shape on ArrayShapeFromConstantArrayReturnRector#4323
samsonasik merged 4 commits intomainfrom
add-object-shape

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 23, 2023 08:22
@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @gitomato

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready ;)

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 914e0e8 into main Jun 23, 2023
@samsonasik samsonasik deleted the add-object-shape branch June 23, 2023 08:32
@gitomato
Copy link
Copy Markdown

Thank you! The fix was insanely quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArrayShapeFromConstantArrayReturnRector breaks when casting array to object

3 participants