Skip to content

[Php55] Clean up FullyQualified assigned to FullyQualified on StringClassNameToClassConstantRector#4284

Merged
samsonasik merged 1 commit intomainfrom
clean-up-f
Jun 19, 2023
Merged

[Php55] Clean up FullyQualified assigned to FullyQualified on StringClassNameToClassConstantRector#4284
samsonasik merged 1 commit intomainfrom
clean-up-f

Conversation

@samsonasik
Copy link
Copy Markdown
Member

No description provided.

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 19, 2023 15:27
@samsonasik samsonasik enabled auto-merge (squash) June 19, 2023 15:27
@samsonasik samsonasik merged commit d9f02ca into main Jun 19, 2023
@samsonasik samsonasik deleted the clean-up-f branch June 19, 2023 15:29
@staabm
Copy link
Copy Markdown
Contributor

staabm commented Jun 19, 2023

@samsonasik @TomasVotruba is it worth supporting php5 rules?

@samsonasik
Copy link
Copy Markdown
Member Author

@staabm we use LevelSetList::UP_TO_PHP_82 which from php 5.2

@staabm
Copy link
Copy Markdown
Contributor

staabm commented Jun 19, 2023

So, we know of projects still running on php5 which use rector to upgrade to php7/8?

@samsonasik
Copy link
Copy Markdown
Member Author

On downgrade, we removing support to downgrade to php 5, but for upgrade, I think that's still a good to have and improve code quality and reduce error prone, eg: on add default value to undefined variable from php 5.6, or make long array syntax short, or remove continue to break syntax;

The "error warning" probably can be hidden, but can be fixed by upgrade the code to remove the limitation of old behaviour via LevelSetList.

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jun 19, 2023

So, we know of projects still running on php5 which use rector to upgrade to php7/8?

Yes, 90 % our private clients start on PHP 5.3-5.6 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants