[Php55] Clean up FullyQualified assigned to FullyQualified on StringClassNameToClassConstantRector#4284
[Php55] Clean up FullyQualified assigned to FullyQualified on StringClassNameToClassConstantRector#4284samsonasik merged 1 commit intomainfrom
Conversation
…lassNameToClassConstantRector
|
@samsonasik @TomasVotruba is it worth supporting php5 rules? |
|
@staabm we use |
|
So, we know of projects still running on php5 which use rector to upgrade to php7/8? |
|
On downgrade, we removing support to downgrade to php 5, but for upgrade, I think that's still a good to have and improve code quality and reduce error prone, eg: on add default value to undefined variable from php 5.6, or make long array syntax short, or remove continue to break syntax; The "error warning" probably can be hidden, but can be fixed by upgrade the code to remove the limitation of old behaviour via |
Yes, 90 % our private clients start on PHP 5.3-5.6 😄 |
No description provided.