Remove Kind from doc mapper, as used just once#4234
Merged
TomasVotruba merged 4 commits intomainfrom Jun 16, 2023
Merged
Conversation
14a264a to
8efafe4
Compare
8efafe4 to
c73bcc6
Compare
6e48bc7 to
74978e8
Compare
Member
|
TypeKind class need to be removed as well? |
Member
|
I see, that used by StaticTypeMapper, we seems have PHPStanStaticTypeMapper vs StaticTypeMapper which the usage seems ambiguous |
Member
|
phpstan notice seems need to be ignored. |
Member
|
@TomasVotruba let's ignore the phpstan notice so it merge-able and make other PR mergeable as well |
Member
|
PHPStan notice ignored 1e572fd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.