[CodeQuality] Handle crash on variable variable on OptionalParametersAfterRequiredRector#4226
Merged
samsonasik merged 5 commits intomainfrom Jun 14, 2023
Merged
[CodeQuality] Handle crash on variable variable on OptionalParametersAfterRequiredRector#4226samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
…AfterRequiredRector
Member
Author
|
Fixed 🎉 /cc @alphpkeemik |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
samsonasik
commented
Jun 14, 2023
| $node->expr->setAttribute(AttributeKey::SCOPE, $mutatingScope); | ||
| } | ||
|
|
||
| $expr = $node; |
Member
Author
There was a problem hiding this comment.
this may need to be cloned to avoid object changed, ref https://3v4l.org/BU1O0
Member
Author
There was a problem hiding this comment.
I tried debug after while, and it seems the object is followed, and target change is different with original node, so it actually ok, see https://3v4l.org/lR4mF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://getrector.com/demo/6ac5df8b-2058-4b72-83e9-646614ef6b00
Fixes rectorphp/rector#7991