Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes#3913
Merged
TomasVotruba merged 2 commits intomainfrom May 21, 2023
Merged
Conversation
samsonasik
reviewed
May 21, 2023
rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php
Outdated
Show resolved
Hide resolved
5cd6703 to
7471b9f
Compare
samsonasik
reviewed
May 21, 2023
rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php
Outdated
Show resolved
Hide resolved
b02c0fe to
1e23baa
Compare
… to only closed scope function likes
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector#7849