Support attributes in RemoveFinalFromEntityRector#3727
Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom May 6, 2023
Merged
Conversation
alexndlm
commented
May 2, 2023
|
|
||
| use Doctrine\ORM\Mapping as ORM; | ||
|
|
||
| #[ORM\Entity]class SomeClass |
Contributor
Author
There was a problem hiding this comment.
This is probably some bug in file writing, but it is not related to this PR.
This syntax is valid.
Member
There was a problem hiding this comment.
This is fine, as using attribute means in php 8.x, the line information is equal with node information, that's why it printed in same line, see:
Re-print the class can solve it, eg:
$node->setAttribute(AttributeKey::ORIGINAL_NODE, null);but that can probably be dangerous as class can have many information that may be loss and re-print may make too many diff.
Member
|
Thank you, this looks good enough 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.