Don't calculate diffs when --no-diffs is given#3710
Merged
samsonasik merged 2 commits intorectorphp:mainfrom Apr 29, 2023
Merged
Don't calculate diffs when --no-diffs is given#3710samsonasik merged 2 commits intorectorphp:mainfrom
--no-diffs is given#3710samsonasik merged 2 commits intorectorphp:mainfrom
Conversation
--no-diffs is given
Contributor
Author
|
do we need the same fix here? when does rector use |
Contributor
Author
perf wise it does not improve performance, but I added it for consistency |
samsonasik
approved these changes
Apr 29, 2023
Member
|
Looks good, thank you @staabm |
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
* Don't calculate diffs when --no-diffs is given * Update ApplicationFileProcessor.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the slowest part of running rector on a file with ~5000 lines of code is generating the diff afterwards
php bin/rector.php -c rector-test.php --dry-run -vvv --debug --no-diffsrefs rectorphp/rector#7899