[Renaming] Improve performance of RenamePropertyRector#3698
Merged
samsonasik merged 3 commits intomainfrom Apr 28, 2023
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
staabm
suggested changes
Apr 28, 2023
| continue; | ||
| } | ||
|
|
||
| $nodeVarType = $this->nodeTypeResolver->getType($propertyFetch->var); |
Contributor
There was a problem hiding this comment.
Before this PR the expensive type-resolving was only needed after the cheap name checks succeeded.
I think instead we should leave the check in the loop but do it only after the classlike instanceof check.
Do you have a concrete real world example you are optimizing for?
Member
Author
There was a problem hiding this comment.
I don't have, probably isset variable inside loop is better..., wdyt?
Contributor
There was a problem hiding this comment.
you could null it before the loop and onyl lazy init it when its still null (and only after the class like instanceof check)
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* [Renaming] Improve performance of RenamePropertyRector * early null assign * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By move get property fetch type before loop.