Improve ParentClassMethodTypeOverrideGuard performance#3660
Merged
samsonasik merged 2 commits intorectorphp:mainfrom Apr 23, 2023
Merged
Improve ParentClassMethodTypeOverrideGuard performance#3660samsonasik merged 2 commits intorectorphp:mainfrom
samsonasik merged 2 commits intorectorphp:mainfrom
Conversation
staabm
commented
Apr 22, 2023
|
|
||
| /** @var string $methodName */ | ||
| $methodName = $this->nodeNameResolver->getName($classMethod); | ||
| $parentClassReflections = array_merge($classReflection->getParents(), $classReflection->getInterfaces()); |
Contributor
Author
There was a problem hiding this comment.
before this change the whole type hierarchy had to be reflected which can be costly.
with this PR we only reflect what on level at a time
| $methodName = $this->nodeNameResolver->getName($classMethod); | ||
| $parentClassReflections = array_merge($classReflection->getParents(), $classReflection->getInterfaces()); | ||
| $parentClassReflection = $classReflection->getParentClass(); | ||
| while ($parentClassReflection !== null) { |
Member
There was a problem hiding this comment.
This should be instanceof check. I'll make a note to make Rector rule to cover these :)
samsonasik
approved these changes
Apr 23, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, thank you @staabm
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
* Improve ParentClassMethodTypeOverrideGuard performance * use instanceof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.