Improve LocalMethodCallFinder performance#3651
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Apr 22, 2023
Merged
Conversation
staabm
commented
Apr 22, 2023
| foreach ($methodCalls as $methodCall) { | ||
| $callerType = $this->nodeTypeResolver->getType($methodCall->var); | ||
| if (! $callerType instanceof TypeWithClassName) { | ||
| if (! $this->nodeNameResolver->isName($methodCall->name, $classMethodName)) { |
Contributor
Author
There was a problem hiding this comment.
doing the cheaper check first so we don't need to resolve the type of every methodcall->var
Contributor
Author
|
the failling job is unrelated. I saw this very same error also on other PRs |
Member
|
That probably due to new phpdoc-parser release https://github.com/phpstan/phpdoc-parser/releases/tag/1.20.1 |
This was referenced Apr 22, 2023
samsonasik
approved these changes
Apr 22, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, thank you @staabm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leads to a 86% faster analysis when running rector on a folder of the phpstan-src codebase