Skip to content

[Php80] Handle crash leaveNode() returned invalid value of type integer on TokenGetAllToObjectRector#3644

Merged
TomasVotruba merged 13 commits intomainfrom
handle-crash-token
Apr 21, 2023
Merged

[Php80] Handle crash leaveNode() returned invalid value of type integer on TokenGetAllToObjectRector#3644
TomasVotruba merged 13 commits intomainfrom
handle-crash-token

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Apr 21, 2023

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @nerones

@samsonasik samsonasik marked this pull request as draft April 21, 2023 07:26
@samsonasik
Copy link
Copy Markdown
Member Author

it seems cause error: Cannot use object of type PhpToken as array

https://3v4l.org/veMeK

$token[0] seems need to be changed to $token->is()

@samsonasik
Copy link
Copy Markdown
Member Author

Ref https://3v4l.org/Ma0RV

@samsonasik samsonasik marked this pull request as ready for review April 21, 2023 14:40
@samsonasik
Copy link
Copy Markdown
Member Author

Finally Fixed 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

Finally 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit c203b60 into main Apr 21, 2023
@TomasVotruba TomasVotruba deleted the handle-crash-token branch April 21, 2023 15:23
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👍

samsonasik added a commit that referenced this pull request May 8, 2023
…er on TokenGetAllToObjectRector (#3644)

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TokenGetAllToObjectRector fails with "leaveNode() returned invalid value of type integer"

3 participants