Fix SingleInArrayToCompareRector if array item is variadic#3640
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Apr 21, 2023
Merged
Fix SingleInArrayToCompareRector if array item is variadic#3640samsonasik merged 3 commits intorectorphp:mainfrom
samsonasik merged 3 commits intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Apr 20, 2023
rules-tests/CodeQuality/Rector/FuncCall/SingleInArrayToCompareRector/Fixture/variadic.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 20, 2023
rules-tests/CodeQuality/Rector/FuncCall/SingleInArrayToCompareRector/Fixture/variadic.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 20, 2023
rules-tests/CodeQuality/Rector/FuncCall/SingleInArrayToCompareRector/Fixture/variadic.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Apr 21, 2023
Member
|
Thank you @raoz |
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
* Add failing test fixture for SingleInArrayToCompareRector Based on https://getrector.com/demo/001ae62c-7857-4ce2-b4c1-8be77fd37568 * fix SingleInArrayToCompareRector in case the array item is variadic * rename SingleInArrayToCompareRector unpacking fixture as suggested by @samsonasik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://getrector.com/demo/001ae62c-7857-4ce2-b4c1-8be77fd37568
Closes rectorphp/rector#7893