Skip to content
/ rector-src Public

[PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::*#3560

Merged
samsonasik merged 5 commits intomainfrom
skip-rem-asterisk
Apr 4, 2023
Merged

[PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::*#3560
samsonasik merged 5 commits intomainfrom
skip-rem-asterisk

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 3, 2023

The following code should be skipped from removal from unused use.

use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;

final class SkipUsedWithAsterisk
{
    /**
     * @param TypeKind::* $typeKind
     */
    public function run(string $typeKind)
    {
    }
}

@samsonasik samsonasik requested a review from TomasVotruba as a code owner April 3, 2023 19:48
@samsonasik
Copy link
Member Author

samsonasik commented Apr 3, 2023

Fixed 🎉

@samsonasik samsonasik changed the title [PostRector] Skip remove unused use on used as asterisk [PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::* Apr 3, 2023
@samsonasik
Copy link
Member Author

samsonasik commented Apr 3, 2023

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

samsonasik commented Apr 4, 2023

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 1da2282 into main Apr 4, 2023
@samsonasik samsonasik deleted the skip-rem-asterisk branch April 4, 2023 00:53
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[PostRector] Skip remove unused use on used as ConstFetchNode, eg: Ty…
3f564bc 
…peKind::* (#3560)

* [PostRector] Skip remove unused use on used as asterisk

* Fixed 🎉

* final touch: eol

* final touch: rename fixture

* rename method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samsonasik