[CodeQuality] Handle multiple ifs on SimplifyIfExactValueReturnValueRector#3527
Merged
samsonasik merged 3 commits intomainfrom Mar 27, 2023
Merged
[CodeQuality] Handle multiple ifs on SimplifyIfExactValueReturnValueRector#3527samsonasik merged 3 commits intomainfrom
samsonasik merged 3 commits intomainfrom
Conversation
Member
Author
|
For another statement after return, there is rule for that: All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…ector (#3527) * [CodeQuality] Handle multiple ifs on SimplifyIfExactValueReturnValueRector * [CodeQuality] Handle multiple ifs on SimplifyIfExactValueReturnValueRector * return to be last stmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue of PR:
return early null cause muti ifs don't get applied, this PR continue to next statement to support multiple ifs.