[Caching] Alternative Fix caching on change config cache not cleared#3483
Merged
samsonasik merged 1 commit intomainfrom Mar 16, 2023
Merged
[Caching] Alternative Fix caching on change config cache not cleared#3483samsonasik merged 1 commit intomainfrom
samsonasik merged 1 commit intomainfrom
Conversation
Member
Author
|
@TomasVotruba this is safer than #3479 as it doesn't immediately clear the cache on switching between projects that the config cache still null to be filled. Instead, this PR make change of cache key to make consistent with other cache key usage in other methods instead of using |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jackbentley this is alternative of PR:
also make consistent with key definition instead of the value of key on other methods.
Closes #3479
Fixes rectorphp/rector#7835