Skip to content
/ rector-src Public

Handle $reflectionProperty->getDefaultValueExpression() return null#3446

Merged
samsonasik merged 4 commits intomainfrom
hanlde-default-value-expr-null
Mar 3, 2023
Merged

Handle $reflectionProperty->getDefaultValueExpression() return null#3446
samsonasik merged 4 commits intomainfrom
hanlde-default-value-expr-null

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Mar 3, 2023 •
edited
Loading

Ref rector-doctrine test error https://github.com/rectorphp/rector-doctrine/actions/runs/4321563757/jobs/7542937994#step:5:19


 [ERROR] Could not process                                                      
         "/home/runner/work/rector-doctrine/rector-doctrine/src/NodeAnalyzer/Set
         terClassMethodAnalyzer.php" file, due to:                              
         "System error:                                                         
         "PHPStan\BetterReflection\Reflection\Adapter\ReflectionProperty::getDef
         aultValueExpression(): Return value must be of type                    
         PhpParser\Node\Expr, null returned"                                    
         Run Rector with "--debug" option and post the report here: 
https://github.com/rectorphp/rector/issues/new
". On line:

On PR rectorphp/rector-doctrine#154

@samsonasik samsonasik requested a review from TomasVotruba as a code owner March 3, 2023 09:23
@samsonasik samsonasik enabled auto-merge (squash) March 3, 2023 09:55
@samsonasik samsonasik merged commit 658e48f into main Mar 3, 2023
@samsonasik samsonasik deleted the hanlde-default-value-expr-null branch March 3, 2023 10:01
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Mar 3, 2023

Thank you 👍

Github Actions were down yesterday evening so I missed this.

@samsonasik samsonasik mentioned this pull request Mar 3, 2023
Merged
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
Handle $reflectionProperty->getDefaultValueExpression() return null (#…
6e33caf 
…3446)

* Handle $reflectionProperty->getDefaultValueExpression() return null

* fix

* fix

* pull from BetterReflection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @TomasVotruba