-
-
Notifications
You must be signed in to change notification settings - Fork 742
Closed
Labels
Description
1. Remove next/prev/stmts/node relations ✔️
2. Separate @api public methods from another packages
3. Remove global Scope attribute and pass it where needed
4. Remove removeNode() and addNodeBefore/After() ✔️
- these methods are like scratching by your left foot behind your right ear - messy for no reason
- instead use direct node removal right in the rule
- same for adding nodes - return multiple nodes to return
5. Remove cyclic dependencies in with #[Required]
- the cyclic dependency suggests design smell, that should be refactored to clear dependency tree or adjust the rules
6. Remove HTML+PHP mix ✔️
The HTML and PHP mix is not covered by php-parser well. That's why lot of refactoring handled by Rector and cut in the middle and crash in a weird mess, duplicated lines, open-tags, new lines in new places or missing part of PHP code. We've tried to improve this part, but untill it's included in php-parser itself, we only patch new wounds. To avoid breaking code in unexpected spaces and make Rector reliable, we'll avoid any HTML+PHP code mix in next version. Separate these files to template code and PHP file, to enjoy the full power of Rector.
Reactions are currently unavailable