Adapt Http2SettingsSpecTests to new netty error messages #2795
Merged
pderop merged 1 commit intoreactor:1.0.xfrom May 4, 2023
Merged
Conversation
violetagg
approved these changes
May 4, 2023
Contributor
Author
|
@violetagg , thanks for the review. |
pderop
added a commit
that referenced
this pull request
May 4, 2023
Http2SettingsSpecTests to new netty error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to adapt the Http2SettingsSpecTests, because since Netty PR#13369, the messages of the IllegalArgumentExceptions thrown when invalid Http2Settings are used have changed, and the following tests in the reactor-netty
Http2SettingsSpecTeststest are not passing anymore:Since the Netty PR is only available in 4.1.93.Final-SNAPSHOT, let's compare the exceptions messages using
withMessageContaininginstead ofwithMessage, this will ensure that the test passes with current netty 4.1.92.Final as well as with 4.1.93.Final-SNAPSHOT.