fix: make mode and reValidateMode reactive#12803
Merged
bluebill1049 merged 3 commits intoreact-hook-form:masterfrom May 11, 2025
Merged
fix: make mode and reValidateMode reactive#12803bluebill1049 merged 3 commits intoreact-hook-form:masterfrom
mode and reValidateMode reactive#12803bluebill1049 merged 3 commits intoreact-hook-form:masterfrom
Conversation
mode and reValidateMode reactive #12797mode and reValidateMode reactive
Member
|
could you include a unit test for this? |
Contributor
Author
|
Yes, will do |
bluebill1049
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
validationModeBeforeSubmitandvalidationModeAfterSubmitinto theonChangehandler so that we re-compute both modes on every event trigger. This ensures the handler always respects the latest mode and reValidateMode settings instead of relying on stale, one-time values.Related issue: #12797
Type of change