add missing cuda 12.9 ray-extra#59495
Conversation
add missing cuda 12.9 ray-extra Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request adds the cu12.9.1-cudnn platform for building ray-extra images. The change in .buildkite/build.rayci.yml is correct on its own, but it appears to be incomplete. A corresponding change to define this new platform in ci/ray_ci/docker_container.py seems to be missing. This omission could cause issues in other parts of the CI pipeline that rely on a central list of platforms. I've added a comment with more details.
| --platform cu12.1.1-cudnn8 --platform cu12.3.2-cudnn9 | ||
| --platform cu12.4.1-cudnn --platform cu12.5.1-cudnn | ||
| --platform cu12.6.3-cudnn --platform cu12.8.1-cudnn | ||
| --platform cu12.9.1-cudnn |
There was a problem hiding this comment.
This change appears to be incomplete. When adding a new platform like cu12.9.1-cudnn, it should also be defined in the list of supported platforms, which appears to be PLATFORMS_RAY in ci/ray_ci/docker_container.py. Without this definition, other CI steps that rely on this list, such as the image index generation script (ci/ray_ci/automation/generate_index.py), may fail or not work as expected for this new platform.
cherrypick #59494 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
cherrypick ray-project#59494 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
cherrypick #59494