[release] keep building python 3.9 wheel for internal testing#58732
Merged
aslonnie merged 1 commit intoreleases/2.52.0from Nov 18, 2025
Merged
[release] keep building python 3.9 wheel for internal testing#58732aslonnie merged 1 commit intoreleases/2.52.0from
aslonnie merged 1 commit intoreleases/2.52.0from
Conversation
still used in some of the release tests Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the building of Python 3.9 wheels for internal testing by adding 3.9 back to the build matrix in the Buildkite configuration. The change is straightforward and aligns with the stated purpose. My only suggestion is to add a comment to the configuration file to document why this version is being kept, which will improve future maintainability.
| commands: | ||
| - bazel run //ci/ray_ci:build_in_docker -- wheel --python-version {{matrix}} --architecture x86_64 --upload | ||
| matrix: | ||
| - "3.9" |
Contributor
There was a problem hiding this comment.
For better maintainability, it would be helpful to add a comment explaining why Python 3.9 is being kept in the build matrix, referencing the reason mentioned in the pull request description. This will provide context for future developers who might consider removing it.
# Kept for internal release tests. Can be removed once we fully drop Python 3.9 support.
- "3.9"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still used in some of the release tests