Skip to content

fix(table): ensure render offset without selection properly#1187

Merged
joshka merged 4 commits intomainfrom
jm/fix-table-offset-bug
Jun 18, 2024
Merged

fix(table): ensure render offset without selection properly#1187
joshka merged 4 commits intomainfrom
jm/fix-table-offset-bug

Conversation

@joshka
Copy link
Copy Markdown
Member

@joshka joshka commented Jun 17, 2024

Fixes: #1179

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.4%. Comparing base (4bfdc15) to head (6eb0126).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1187     +/-   ##
=======================================
+ Coverage   94.3%   94.4%   +0.1%     
=======================================
  Files         60      62      +2     
  Lines      14679   14935    +256     
=======================================
+ Hits       13843   14105    +262     
+ Misses       836     830      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka force-pushed the jm/fix-table-offset-bug branch from 1caed72 to 2b9464e Compare June 17, 2024 12:12
@EdJoPaTo EdJoPaTo changed the title fix(table): enusre that table renders offset without selection properly fix(table): ensure render offset without selection properly Jun 17, 2024
Comment thread src/widgets/table/table.rs Outdated
Comment thread src/widgets/table/table.rs Outdated
@joshka joshka requested a review from EdJoPaTo June 18, 2024 01:17
Comment thread src/widgets/table/table.rs Outdated
Comment thread src/widgets/table/table.rs Outdated
@joshka joshka requested a review from EdJoPaTo June 18, 2024 10:19
@joshka joshka merged commit 127d706 into main Jun 18, 2024
@joshka joshka deleted the jm/fix-table-offset-bug branch June 18, 2024 10:55
itsjunetime pushed a commit to itsjunetime/ratatui that referenced this pull request Jun 23, 2024
joshka added a commit to erak/ratatui that referenced this pull request Oct 14, 2024
takumi-earth pushed a commit to earthlings-dev/ratatui that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableState resets offset to 0

2 participants