fix #197: return sync callback when using the sync interface, otherwise return the async callback#220
fix #197: return sync callback when using the sync interface, otherwise return the async callback#220silkentrance merged 4 commits intomasterfrom
Conversation
|
file tests using name option fails in before hook on appveyor while it succeeds on both my local linux machine and travis. need to investigate this further: file tests are run after dir tests. it seems as if the temporary directory created by the dir tests had not been removed, even though that the assertion for checking whether the directory does not exists will not fail during testing. for now, putting a guard around the call to the sync cleanup callback in case that fileSync tests leave behind some remnants. next: test this on a windows machine. |
|
actually calling the sync cleanup callback during test seems to have done the trick. |
|
TODO: we might have a missing test here: sync file and dir operations must return the fully qualified path and not just the name that was either provided in the opts or that was generated by tmpName*. then again, we have in assertions both assertExists and assertDoesNotExist. so we need to investigate, better be sure than sorry. |
internally, we still use the synchronous remove functions on process exit.