Skip to content

Respect implicit encoding of thorfiles#782

Merged
rafaelfranca merged 2 commits into
rails:mainfrom
timdiggins:respect-implicit-encoding-of-thorfiles
Jun 17, 2022
Merged

Respect implicit encoding of thorfiles#782
rafaelfranca merged 2 commits into
rails:mainfrom
timdiggins:respect-implicit-encoding-of-thorfiles

Conversation

@timdiggins

Copy link
Copy Markdown
Contributor

🌈 fixes #776

@timdiggins

Copy link
Copy Markdown
Contributor Author

PS this has the #780 PR in it - will need to rebase once it has been merged.

Comment thread spec/parser/options_spec.rb Outdated
@timdiggins timdiggins mentioned this pull request Mar 10, 2022
@timdiggins timdiggins force-pushed the respect-implicit-encoding-of-thorfiles branch from 9f46c83 to c4f445e Compare June 16, 2022 17:01
@timdiggins

Copy link
Copy Markdown
Contributor Author

@dorner @deivid-rodriguez I've rebased this on main, now it's (mostly) green

@rafaelfranca rafaelfranca merged commit 8c9817d into rails:main Jun 17, 2022
@timdiggins timdiggins deleted the respect-implicit-encoding-of-thorfiles branch June 17, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

thor files have default encoding of ASCII-8BIT, not UTF-8

3 participants