Prefer to use URI.open and File.open instead of Kernel.open#802
Merged
Conversation
Contributor
|
I fixed the |
Contributor
Author
|
Oh! Thanks to share it. |
Contributor
|
Should we enable Security/Open in RuboCop configuration file too? |
Contributor
Author
|
👍 or add CodeQL actions. |
Contributor
|
That too, just thought of RuboCop since it's already used. |
Member
|
Can you please rebase this PR? |
47d4a06 to
c88f213
Compare
c88f213 to
16db563
Compare
Contributor
Author
|
@rafaelfranca done 🚀 |
Contributor
Author
|
Thanks @rafaelfranca ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 CodeQL detects "Use of
Kernel.openorIO.readwith a non-constant value" warnings in https://github.com/ruby/ruby. I hope to suppress them.