Fix pin_all_from incorrectly removing "js" substring from filenames#313
Merged
rafaelfranca merged 2 commits intomainfrom Aug 1, 2025
Merged
Fix pin_all_from incorrectly removing "js" substring from filenames#313rafaelfranca merged 2 commits intomainfrom
pin_all_from incorrectly removing "js" substring from filenames#313rafaelfranca merged 2 commits intomainfrom
Conversation
When using pin_all_from, filenames containing "js" as a substring (like "foo.jszip.js" or "bar.jsmin.js") were having the substring incorrectly removed, resulting in malformed module names like "foozip" and "barmin" instead of "foo.jszip" and "bar.jsmin". Fixed the logic to only remove the file extension from the end of the filename, preserving any "js" substrings that appear elsewhere in the name. Fixes #282
| 3. **Fix Implementation**: The actual code changes made | ||
| 4. **Verification**: Results of running tests and any additional validation | ||
|
|
||
| Remember: Always write tests first, then implement the fix to make them pass. This ensures you truly understand and solve the problem. |
There was a problem hiding this comment.
@rafaelfranca — general thing to consider incorporating into AI workflow ... knowing when the specs shouldn't be left at the end (e.g., write a spec to see if fail, then fix + see it pass, then delete spec).
Example for an existing memory leak that was discovered:
- demonstrate leak via Vitest/Jest (commit)
- fix + push (commit -> see spec pass)
- cleanup (delete spec)
I think it makes sense to keep all the specs you wrote here; just a general suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using pin_all_from, filenames containing "js" as a substring (like "foo.jszip.js" or "bar.jsmin.js") were having the substring incorrectly removed, resulting in malformed module names like "foozip" and "barmin" instead of "foo.jszip" and "bar.jsmin".
Fixed the logic to only remove the file extension from the end of the filename, preserving any "js" substrings that appear
elsewhere in the name.
Fixes #282