Fix specification of SERVER_PORT.#2296
Merged
Merged
Conversation
jeremyevans
approved these changes
Feb 24, 2025
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Please add a CHANGELOG entry. I know the enforcement has not changed (modulo 0x prefix and similar), but since the wording has changed, I think we should note it. You can put it under Bug Fixes instead of SPEC changes, since the previous SPEC wording is really a bug (since the value could not be an integer).
27dc4a0 to
46a6ae7
Compare
46a6ae7 to
fa0e2d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2293 for context.