Avoid wrapping nil input#2259
Merged
Conversation
tt
commented
Nov 8, 2024
ioquatix
reviewed
Nov 8, 2024
jeremyevans
approved these changes
Nov 8, 2024
Member
|
Thanks for your contribution. I hope we can release this in Rack 3.2 sometime before the end of this year. |
Contributor
Author
|
@ioquatix, is there a new timeline for when Rack 3.2 is expected to ship? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack ships with the
Rack::RewindableInput::Middlewaremiddleware for compatibility with older apps.However, this middleware wraps
rack.inputunconditionally meaning that a nil input will also be wrapped potentially leading to exceptions.Concretely, I have an older app with a middleware that's trying to
req.body&.readandreq.body&.rewindwhich forGETandHEADrequests now cause the following error:This middleware should probably interrogate
req.request_method.Even so, it seems that for backwards compatibility (and to avoid the possibility of runtime errors overall), it would be great to never wrap a nil value.