Invalid cookie keys will now raise an error. #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02f4839 to
b4ff29f
Compare
jeremyevans
requested changes
Jun 11, 2024
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
The unrelated changes to the CHANGELOG and version file makes it look like something went wrong in a rebase.
Member
Author
|
Yeah not sure what happened here, the PR is completely bananas. I'll fix it. |
b4ff29f to
b3154af
Compare
jeremyevans
approved these changes
Jun 11, 2024
Contributor
|
@tenderlove Looks like you released this change with rack 3.1.1 (https://my.diffend.io/gems/rack/3.1.0/3.1.1) |
Member
|
argh, sorry about that. I shipped the wrong branch. I'll fix it. |
Member
|
@dentarg v3.1.2 should be shipped now |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2191 for Rack 3.2+.