Support for the Partitioned cookie attribute#2131
Merged
Conversation
Adds the option to include the `Partitioned` cookie attribute, required by Chrome in some contexts. Raises an error if `secure` is not set.
Member
|
Thanks! Do you mind writing some tests for this? |
Contributor
Author
|
Just added a couple of tests. I hope this is good. I'm not too familiar with the repo. |
jeremyevans
reviewed
Oct 22, 2023
The user can set the necessary attributes explicitly.
Contributor
Author
|
Is there anything else I can do to help with this PR? I marked the previous conversation resolved but not sure if there's some other step. |
Contributor
|
Hi @flavio-b, Could you edit the pull request description since the error part changed? |
Contributor
Author
|
@mikegee, done! |
Member
|
Can you please add a note to the change log and then we can merge. |
ioquatix
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to include the
Partitionedcookie attribute, required by Chrome in some contexts.