expose local and remote settings in ConnectionState#5533
expose local and remote settings in ConnectionState#5533marten-seemann merged 1 commit intomasterfrom
Conversation
Expose separate local and remote datagram and stream reset partial delivery flags via
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
+ Coverage 84.16% 84.17% +0.02%
==========================================
Files 159 159
Lines 16366 16364 -2
==========================================
+ Hits 13773 13774 +1
+ Misses 1958 1956 -2
+ Partials 635 634 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR converts the SupportsDatagrams and SupportsStreamResetPartialDelivery fields in ConnectionState from simple boolean values to struct types with Remote and Local fields. This breaking API change allows applications to separately check whether datagram and reliable stream reset support is enabled locally versus advertised by the remote peer.
Key Changes:
- Changed
ConnectionState.SupportsDatagramsfromboolto a struct withRemoteandLocalbool fields - Changed
ConnectionState.SupportsStreamResetPartialDeliveryfromboolto a struct withRemoteandLocalbool fields - Updated
ConnectionState()method to dynamically populate both local and remote support flags on each call instead of caching values
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| interface.go | Changed SupportsDatagrams and SupportsStreamResetPartialDelivery from bool fields to structs with Remote and Local bool fields |
| connection.go | Updated ConnectionState() to populate both Remote and Local fields dynamically; removed old caching logic from restoreTransportParameters and handleTransportParameters |
| http3/conn.go | Updated datagram support check to use SupportsDatagrams.Remote field |
| integrationtests/self/zero_rtt_test.go | Updated tests to check both Remote and Local fields separately |
| integrationtests/self/handshake_test.go | Updated tests to check both Remote and Local fields separately with descriptive messages |
| integrationtests/self/datagram_test.go | Enhanced tests to verify both endpoints' views of local and remote datagram support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This allows the application to check for datagram and reliable stream reset support for both the local and the remote side.
b63a964 to
ad2061e
Compare
This allows the application to check for datagram and reliable stream reset support for both the local and the remote side.