remove deprecated ConnectionTracingID and ConnectionTracingKey#5521
remove deprecated ConnectionTracingID and ConnectionTracingKey#5521marten-seemann merged 1 commit intomasterfrom
Conversation
Remove deprecated connection tracing from server and client contexts by deleting
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
+ Coverage 84.02% 84.06% +0.04%
==========================================
Files 159 159
Lines 16338 16334 -4
==========================================
+ Hits 13728 13731 +3
+ Misses 1976 1972 -4
+ Partials 634 631 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR removes the long-deprecated ConnectionTracingID and ConnectionTracingKey API, which are no longer needed after the introduction of a new WebTransport API (as described in issue #4405). Applications can now set their own tracing keys using Transport.ConnContext instead.
- Removed the deprecated public API types and constants from
interface.go - Removed all internal implementation and usage throughout the codebase
- Updated integration tests to remove assertions on the deprecated API
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| interface.go | Removed deprecated ConnectionTracingKey, ConnectionTracingID, and connTracingCtxKey type definitions |
| connection.go | Removed connTracingID atomic variable and nextConnTracingID() helper function |
| transport.go | Removed code that added ConnectionTracingKey to context in doDial() |
| server.go | Removed code that added ConnectionTracingKey to context in handleInitialImpl() |
| integrationtests/self/http_test.go | Removed test assertions that verified ConnectionTracingID values in connection contexts |
The changes are clean and complete. All references to the deprecated API have been successfully removed from the codebase, and the remaining code functions correctly without it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Now that we have a new API for WebTransport (#4405), we don't need the long deprecated
ConnectionTracingIDand the associatedConnectionTracingKeyanymore.