use synctest for the RTT and reordering tests#5464
Merged
marten-seemann merged 1 commit intomasterfrom Dec 2, 2025
Merged
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
1728452 to
ced9c86
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the RTT and reordering integration tests from using a proxy-based approach to using synctest for deterministic time control and simnet for network simulation. This modernization improves test reliability and removes dependencies on the legacy proxy infrastructure.
Key Changes
- Migrated to synctest: Both tests now use
synctest.Test()wrapper for deterministic time control, eliminating timing-related flakiness - Replaced proxy with simnet: Network conditions are now simulated using the
simnetpackage instead of thequicproxypackage, providing more precise control over latency and bandwidth - Enhanced RTT validation: Added explicit RTT assertions in
TestDownloadWithFixedRTTto verify both client and server measure the expected RTT values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
818f225 to
80ad82c
Compare
4bdd948 to
2903d7f
Compare
80ad82c to
bcfe8d9
Compare
bcfe8d9 to
e391302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5463.