use synctest for the packet drop test#5393
Merged
marten-seemann merged 1 commit intomasterfrom Oct 21, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5393 +/- ##
==========================================
+ Coverage 83.15% 83.19% +0.04%
==========================================
Files 159 159
Lines 19252 19252
==========================================
+ Hits 16008 16016 +8
+ Misses 2617 2611 -6
+ Partials 627 625 -2 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the packet drop test from using a proxy-based approach to using synctest with a simulated network, significantly improving test performance from 2-3 seconds to instantaneous execution.
- Replaced proxy-based packet dropping with simnet router implementation
- Extracted droppingRouter to a shared helper file to avoid duplication
- Updated test logic to use protocol perspectives instead of proxy directions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integrationtests/self/simnet_helper_test.go | New shared helper file containing the droppingRouter implementation |
| integrationtests/self/drop_test.go | Complete rewrite of packet drop test using synctest and simnet instead of proxy |
| integrationtests/self/close_test.go | Removed duplicate droppingRouter definition, now uses shared helper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e698f3c to
781dbe7
Compare
361fe67 to
cb7f6ad
Compare
781dbe7 to
5a81468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test used to take 2-3s, with synctest they're now instantaneous.