http3: add the qlog event schema to trace header#5383
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for HTTP3-specific qlog event schemas to the trace header infrastructure. The key purpose is to enable HTTP3 event logging alongside existing QUIC event logging by introducing schema support checking and allowing traces to support multiple event schemas.
- Adds a
SupportsSchemasmethod to theTraceinterface to check if a trace supports specific event schemas - Introduces HTTP3 event schema constant and default connection tracer
- Updates existing tracers to support both QUIC and HTTP3 event schemas
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testutils/events/event_recorder.go | Implements SupportsSchemas method for test trace |
| qlogwriter/writer.go | Adds SupportsSchemas interface method and eventSchemas field to FileSeq |
| qlog/qlog_dir.go | Adds DefaultConnectionTracerWithSchemas function to support multiple schemas |
| interop/utils/logging.go | Updates to include HTTP3 event schema in tracer |
| integrationtests/tools/qlog.go | Updates to include HTTP3 event schema in tracer |
| integrationtests/self/self_test.go | Implements SupportsSchemas method for multiplexed trace |
| http3/server.go | Adds schema support check before creating qlog producer |
| http3/qlog/qlog_dir.go | Creates new HTTP3 qlog package with event schema constant |
| example/main.go | Updates import to use HTTP3-specific qlog package |
| example/client/main.go | Updates import to use HTTP3-specific qlog package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5383 +/- ##
==========================================
+ Coverage 83.19% 83.21% +0.02%
==========================================
Files 158 159 +1
Lines 19216 19227 +11
==========================================
+ Hits 15986 15999 +13
+ Misses 2606 2605 -1
+ Partials 624 623 -1 ☔ View full report in Codecov by Sentry. |
973f620 to
7d1e034
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7d1e034 to
8ab4893
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Part of #4124.