http3: qlog the frame length and payload length of parsed frames#5380
Merged
marten-seemann merged 1 commit intomasterfrom Oct 12, 2025
Merged
http3: qlog the frame length and payload length of parsed frames#5380marten-seemann merged 1 commit intomasterfrom
marten-seemann merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances HTTP3 frame logging by adding frame length information to qlog events. The main purpose is to record both the complete frame length (including header) and payload length for parsed frames to improve debugging capabilities.
- Added frame header length tracking for all HTTP3 frame types
- Updated qlog events to include both total frame length and payload length
- Refactored frame parsing to use a shared counting byte reader
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| http3/frames.go | Introduces countingByteReader for tracking bytes read and updates frame parsing to record frame lengths |
| http3/qlog.go | Updates qlogParsedHeadersFrame to accept headersFrame struct and record both frame and payload lengths |
| http3/stream.go | Changes parseTrailer function signature to accept *headersFrame instead of uint64 |
| http3/conn.go | Updates decodeTrailers to work with headersFrame struct instead of length parameter |
| http3/capsule.go | Removes duplicate countingByteReader definition and uses the one from frames.go |
| http3/http3_helper_test.go | Adds expectedFrameLength helper function for testing frame length calculations |
| http3/*_test.go | Updates test files to use new function signatures and validate frame length logging |
Comments suppressed due to low confidence (1)
http3/frames.go:1
- The panic statement is unreachable because the switch statement above handles all cases and includes a default case that calls t.Fatalf(). This line should be removed.
package http3
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5380 +/- ##
==========================================
- Coverage 83.06% 83.06% -0.00%
==========================================
Files 158 158
Lines 19114 19137 +23
==========================================
+ Hits 15876 15895 +19
- Misses 2613 2616 +3
- Partials 625 626 +1 ☔ View full report in Codecov by Sentry. |
e20397d to
4c35ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4124.