http3: qlog sent and received SETTINGS frames#5379
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements qlog (QUIC logging) support for HTTP/3 SETTINGS frames, enabling the logging of both sent and received SETTINGS frames as part of issue #4124. The changes add comprehensive qlog instrumentation to capture SETTINGS frame creation and parsing events.
- Added qlog recording for SETTINGS frame creation in both client and server code
- Implemented SETTINGS frame parsing with qlog events for received frames
- Added comprehensive test coverage for SETTINGS frame qlog functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| http3/qlog/frame.go | Added SettingsFrame struct and encoding logic for qlog output |
| http3/qlog/frame_test.go | Added comprehensive test cases for SettingsFrame qlog encoding |
| http3/server.go | Added qlog recording when server sends SETTINGS frames |
| http3/client.go | Added qlog recording when client sends SETTINGS frames |
| http3/frames.go | Modified SETTINGS frame parsing to record qlog events and added pointer helper |
| http3/http3_helper_test.go | Added utility function to filter qlog events by frame type |
| http3/server_test.go | Updated test to use new filtering helper function |
| http3/conn_test.go | Enhanced tests to verify qlog events for SETTINGS frames |
| http3/client_test.go | Enhanced tests to verify qlog events for SETTINGS frames |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
==========================================
+ Coverage 82.98% 83.02% +0.04%
==========================================
Files 158 158
Lines 19034 19114 +80
==========================================
+ Hits 15795 15869 +74
- Misses 2614 2618 +4
- Partials 625 627 +2 ☔ View full report in Codecov by Sentry. |
59ffd1e to
eea524b
Compare
Part of #4124.