http3: add basic client-side qlog support#5374
Merged
marten-seemann merged 1 commit intomasterfrom Oct 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic client-side qlog support for HTTP/3 by integrating qlog event recording for frame parsing and creation operations.
Key changes:
- Integration of qlog event recording for HTTP/3 frame operations
- Update of request writer interface to accept qlog recorder parameter
- Addition of comprehensive test coverage for qlog event recording
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| http3/stream_test.go | Updates tests to use new connection setup with event recorder and validates qlog frame events |
| http3/stream.go | Adds qlog event recording for data frame parsing and invalid headers frame scenarios |
| http3/response_writer_test.go | Minor refactoring to move variable declaration closer to usage |
| http3/request_writer_test.go | Enhances request writer tests with qlog event validation and stream ID parameters |
| http3/request_writer.go | Extends request writer interface to support qlog recording for header frame creation |
| http3/http3_helper_test.go | Updates helper function call to match new request writer interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5374 +/- ##
==========================================
+ Coverage 83.07% 83.10% +0.04%
==========================================
Files 158 158
Lines 18939 18963 +24
==========================================
+ Hits 15732 15759 +27
+ Misses 2584 2581 -3
Partials 623 623 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4124.