qlogwriter: add support for event_schemas in the trace header#5361
qlogwriter: add support for event_schemas in the trace header#5361marten-seemann merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for event_schemas in the qlog trace header to specify which event schemas are used in the trace. The changes introduce an eventSchemas parameter to qlog file creation functions and ensure the event_schemas field is properly included in the JSON output when schemas are provided.
- Modified qlog writer functions to accept event schemas as a parameter
- Added EventSchema constant for QUIC event schema URN
- Updated all callers to pass the QUIC event schema when creating connection traces
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| qlogwriter/writer.go | Added eventSchemas parameter to file creation functions |
| qlogwriter/trace.go | Added EventSchemas field to trace header and JSON encoding logic |
| qlogwriter/trace_test.go | Updated tests to verify event_schemas field handling |
| qlog/qlog_dir.go | Added EventSchema constant and updated DefaultConnectionTracer |
| qlog/benchmark_test.go | Updated benchmark to include event schema parameter |
| interop/utils/logging.go | Updated qlog creation to include event schema |
| integrationtests/tools/qlog.go | Updated qlog creation to include event schema |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5361 +/- ##
==========================================
- Coverage 83.04% 82.97% -0.06%
==========================================
Files 156 156
Lines 18723 18736 +13
==========================================
- Hits 15547 15546 -1
- Misses 2563 2574 +11
- Partials 613 616 +3 ☔ View full report in Codecov by Sentry. |
bbd4029 to
6058118
Compare
6058118 to
5c94f18
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Depends on #5360.