use synctest in more connection tests#5357
Merged
marten-seemann merged 1 commit intomasterfrom Oct 6, 2025
Merged
Conversation
No functional change expected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5357 +/- ##
==========================================
+ Coverage 84.11% 84.15% +0.04%
==========================================
Files 158 158
Lines 18730 18730
==========================================
+ Hits 15754 15762 +8
+ Misses 2355 2348 -7
+ Partials 621 620 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional change expected.
#5356 requires a few more test cases to use
synctest. This PR is an attempt to (slightly) reduce the size of that PR.