ci: remove 386 (32 bit x86)#5352
Merged
marten-seemann merged 1 commit intoquic-go:masterfrom Oct 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5352 +/- ##
==========================================
+ Coverage 84.23% 84.33% +0.10%
==========================================
Files 156 157 +1
Lines 17904 18008 +104
==========================================
+ Hits 15081 15187 +106
+ Misses 2248 2245 -3
- Partials 575 576 +1 ☔ View full report in Codecov by Sentry. |
marten-seemann
requested changes
Oct 2, 2025
Member
marten-seemann
left a comment
There was a problem hiding this comment.
What about the unit tests (unit.yml). There's a 32 bit step there as well.
7fb177f to
f347cc9
Compare
Member
|
@MarcoPolo Are you planning to address the remaining review comments? |
The last 386 cpu was from 20 years ago (Pentium 4)
f347cc9 to
876057b
Compare
Collaborator
Author
|
ah sorry, I thought I had pushed |
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last 386 cpu was from 20 years ago (Pentium 4)