ackhandler: avoid calling time.Now() when generating ACK frame#4886
Merged
marten-seemann merged 1 commit intomasterfrom Jan 18, 2025
Merged
ackhandler: avoid calling time.Now() when generating ACK frame#4886marten-seemann merged 1 commit intomasterfrom
marten-seemann merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4886 +/- ##
==========================================
- Coverage 83.38% 83.38% -0.01%
==========================================
Files 151 151
Lines 16217 16230 +13
==========================================
+ Hits 13522 13532 +10
- Misses 2158 2160 +2
- Partials 537 538 +1 ☔ View full report in Codecov by Sentry. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4885. It's better to pass in the timestamp from the connection.