remove validation enforcing one Transport per net.PacketConn#4851
Merged
marten-seemann merged 1 commit intomasterfrom Jan 10, 2025
Merged
remove validation enforcing one Transport per net.PacketConn#4851marten-seemann merged 1 commit intomasterfrom
marten-seemann merged 1 commit intomasterfrom
Conversation
It is invalid to use a net.PacketConn in multiple Transports. However, the validation logic is causing pain when using wrapped net.PacketConns. It was introduce to guard against incorrect uses of the API when the Transport was introduced, but this is probably less relevant now than it was back then.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4851 +/- ##
==========================================
- Coverage 83.73% 83.70% -0.03%
==========================================
Files 149 148 -1
Lines 16095 16060 -35
==========================================
- Hits 13476 13442 -34
- Misses 2089 2090 +1
+ Partials 530 528 -2 ☔ View full report in Codecov by Sentry. |
MarcoPolo
approved these changes
Jan 9, 2025
Collaborator
MarcoPolo
left a comment
There was a problem hiding this comment.
Nice to see the large deletions 🗑️
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is invalid to use a
net.PacketConnin multipleTransports. However, the validation logic is causing pain when using wrappednet.PacketConns. It was introduce to guard against incorrect uses of the API when theTransportwas introduced, but this is probably less relevant now than it was back then.