stream: don't cancel stream after shutdown#4673
Merged
marten-seemann merged 1 commit intomasterfrom Sep 14, 2024
Merged
Conversation
617a898 to
dc78a0a
Compare
This ensures that `stream.Write` and `stream.Read` return the error code from connection close, if the stream was closed as a result of connection close.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4673 +/- ##
==========================================
- Coverage 84.78% 84.75% -0.03%
==========================================
Files 150 150
Lines 14917 14922 +5
==========================================
Hits 12647 12647
- Misses 1742 1746 +4
- Partials 528 529 +1 ☔ View full report in Codecov by Sentry. |
dc78a0a to
c6c7b20
Compare
marten-seemann
approved these changes
Sep 13, 2024
Member
marten-seemann
left a comment
There was a problem hiding this comment.
Nice find!
Really appreciate the meaningful test cases as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that
stream.Writeandstream.Readreturn the error codefrom connection close, if the stream was closed as a result of
connection close.