Skip to content

handshake: migrate tests away from Ginkgo#4667

Merged
marten-seemann merged 1 commit intomasterfrom
translate-handshake-tests
Oct 12, 2024
Merged

handshake: migrate tests away from Ginkgo#4667
marten-seemann merged 1 commit intomasterfrom
translate-handshake-tests

Conversation

@marten-seemann
Copy link
Copy Markdown
Member

@marten-seemann marten-seemann commented Sep 10, 2024

Part of #3652.

@marten-seemann marten-seemann added this to the v0.48 milestone Sep 11, 2024
@marten-seemann marten-seemann force-pushed the translate-handshake-tests branch from c6f84fb to 95d292b Compare September 15, 2024 04:26
@marten-seemann marten-seemann deleted the translate-handshake-tests branch September 15, 2024 04:31
@marten-seemann marten-seemann restored the translate-handshake-tests branch September 21, 2024 12:32
@marten-seemann marten-seemann force-pushed the translate-handshake-tests branch from 95d292b to 8fcda4d Compare October 12, 2024 04:19
@marten-seemann marten-seemann marked this pull request as ready for review October 12, 2024 04:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (72c6180) to head (e269fcf).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/handshake/interface.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4667      +/-   ##
==========================================
+ Coverage   84.78%   84.85%   +0.07%     
==========================================
  Files         150      151       +1     
  Lines       14922    15034     +112     
==========================================
+ Hits        12651    12757     +106     
- Misses       1743     1751       +8     
+ Partials      528      526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the translate-handshake-tests branch from 8fcda4d to 1888254 Compare October 12, 2024 04:26
@marten-seemann marten-seemann force-pushed the translate-handshake-tests branch from 1888254 to e269fcf Compare October 12, 2024 04:27
@marten-seemann marten-seemann merged commit 8754d28 into master Oct 12, 2024
@marten-seemann marten-seemann deleted the translate-handshake-tests branch October 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant