server: fix deadlock when closing concurrently with transport#4332
Merged
marten-seemann merged 2 commits intomasterfrom Mar 3, 2024
Merged
server: fix deadlock when closing concurrently with transport#4332marten-seemann merged 2 commits intomasterfrom
marten-seemann merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4332 +/- ##
==========================================
+ Coverage 84.80% 85.27% +0.47%
==========================================
Files 150 150
Lines 14251 14466 +215
==========================================
+ Hits 12085 12335 +250
+ Misses 1668 1644 -24
+ Partials 498 487 -11 ☔ View full report in Codecov by Sentry. |
Member
|
Does this PR target #4266? |
Collaborator
Author
|
Oh sorry. Yes. I didnt realise there was an open PR. Happy to close this. |
Member
|
#4266 is the issue, not a PR. Please keep this one open. |
Member
|
@sukunrt Did you have a way to reliably trigger this deadlock? If so, would it make sense to add this as a test case here? |
Collaborator
Author
|
On my machine this test is consistently deadlocking on master. |
marten-seemann
approved these changes
Mar 3, 2024
Member
|
Thank you @sukunrt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the listener and transport are closed concurrently. We can get a deadlock
Listener.Closeis inListener.CloseOnce.Doblock and callstransport.closeServerfornotifyOnClose.transport.closeServerrequiresTransport.mutexTransport.Closeholds theTransport.mutexand callsListener.Closeand gets stuck at theListener.closeOnce.Doblock