Skip to content

Verify that we do not exceed the number of tags that can be recorded for HTTP requests#44998

Merged
cescoffier merged 2 commits intoquarkusio:mainfrom
cescoffier:metrics-path-param-test
Jan 16, 2025
Merged

Verify that we do not exceed the number of tags that can be recorded for HTTP requests#44998
cescoffier merged 2 commits intoquarkusio:mainfrom
cescoffier:metrics-path-param-test

Conversation

@cescoffier
Copy link
Copy Markdown
Member

@cescoffier cescoffier commented Dec 9, 2024

This PR adds tests to verify that we do not exceed the number of tags that can be recorded for HTTP requests.
It tests:

  • Jax-RS OK, 400 and 500
  • Reactive routes OK, 400 and 500
  • Programmatic routes OK, 400 and 500

@cescoffier cescoffier requested a review from brunobat December 9, 2024 08:34
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Dec 9, 2024

/cc @brunobat (micrometer), @ebullient (micrometer)

@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Copy Markdown
Member

brunobat commented Dec 9, 2024

Will add a property to activate the blocade to this PR. This will be off by default, for now.

cescoffier and others added 2 commits January 7, 2025 16:13
@cescoffier @brunobat
Verify that we do not exceed the number of tags that can be recorded …
0065a02 
…for HTTP requests

This commits adds tests to verify that we do not exceed the number of tags that can be recorded for HTTP requests.
It tests:

- Jax-RS OK, 400 and 500
- Reactive routes OK, 400 and 500
- Programmatic routes OK, 400 and 500
@brunobat
add configs to suppress uris on 4xx error metrics
7c3c88d
@brunobat brunobat force-pushed the metrics-path-param-test branch from add75a1 to 7c3c88d Compare January 7, 2025 16:15
@brunobat
Copy link
Copy Markdown
Member

brunobat commented Jan 7, 2025

@cescoffier , do you agree with my commit?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 7, 2025

🎊 PR Preview 603b6d6 has been successfully built and deployed to https://quarkus-pr-main-44998-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Jan 7, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7c3c88d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Jan 7, 2025 •
edited by github-actions Bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7c3c88d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier
Copy link
Copy Markdown
Member Author

cescoffier commented Jan 8, 2025

@brunobat yes, it makes sense!

@cescoffier
Copy link
Copy Markdown
Member Author

cescoffier commented Jan 13, 2025

@brunobat ahould we merge it?

@cescoffier cescoffier merged commit a044827 into quarkusio:main Jan 16, 2025
@quarkus-bot quarkus-bot Bot added this to the 3.19 - main milestone Jan 16, 2025
@brunobat
Copy link
Copy Markdown
Member

brunobat commented Jan 17, 2025

Thanks for merging it. I missed your last message.

@cescoffier cescoffier deleted the metrics-path-param-test branch January 29, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunobat brunobat brunobat approved these changes

Assignees

No one assigned

Labels

area/metrics

Projects

None yet

Milestone

3.19.0.CR1

Development

Successfully merging this pull request may close these issues.

2 participants

@cescoffier @brunobat