Skip to content

Add support for encrypted PKCS#8#44549

Merged
gsmet merged 1 commit intoquarkusio:mainfrom
cescoffier:encrypted-pem-support
Nov 18, 2024
Merged

Add support for encrypted PKCS#8#44549
gsmet merged 1 commit intoquarkusio:mainfrom
cescoffier:encrypted-pem-support

Conversation

@cescoffier
Copy link
Copy Markdown
Member

@cescoffier cescoffier commented Nov 17, 2024

Add support for encrypted PEM files (encrypted PKCS#8) to the TLS registry.

Fix #44262.

This is a feature, and it is not intended to be backported.

Add support for encrypted PEM file (encrypted PKCS#8) to the TLS registry. This is invisible for the extensions, the key being decrypted and passed unencrypted to the extensions (the unencrypted key is never written on disk).

Fix quarkusio#44262
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Nov 17, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot Bot added area/dependencies Pull requests that update a dependency file area/documentation labels Nov 17, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 17, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Nov 17, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 3c764a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Nov 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3c764a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@gsmet gsmet merged commit fd597fb into quarkusio:main Nov 18, 2024
@quarkus-bot quarkus-bot Bot added this to the 3.18 - main milestone Nov 18, 2024
@quarkus-bot quarkus-bot Bot added the kind/enhancement New feature or request label Nov 18, 2024
@gsmet
Copy link
Copy Markdown
Member

gsmet commented Nov 18, 2024

@cescoffier you don't want us to shoe it in 3.17.0 either? Asking because it's not always clear that given we are already past CR1, it would require a backport. Otherwise, this will target 3.18. Your choice really.

@cescoffier
Copy link
Copy Markdown
Member Author

@gsmet It can wait 3.18.

@shawkins
Copy link
Copy Markdown
Contributor

shawkins commented Aug 6, 2025

@cescoffier how is bcfks supported with the tls registry configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supported encrypted pem files in the TLS registry

3 participants