Stop using ctypes for traceback mutation#3203
Merged
A5rocks merged 3 commits intopython-trio:mainfrom Feb 11, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18792 18760 -32
Branches 1268 1267 -1
===============================================
- Hits 18792 18760 -32
🚀 New features to boost your workflow:
|
CoolCat467
requested changes
Feb 9, 2025
Member
CoolCat467
left a comment
There was a problem hiding this comment.
Looks great other than a few comments that are now outdated
CoolCat467
approved these changes
Feb 10, 2025
jakkdl
approved these changes
Feb 10, 2025
Member
jakkdl
left a comment
There was a problem hiding this comment.
don't really understand the magic going on, but if tests are passing then I assume it's fine
Contributor
Author
|
The pypy version is simpler to understand (at least imo) as a version to compare to. ... but yeah I'm hopeful that I didn't miss anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405
It's kind of unnecessary since we'll rip this code out anyways once strict exception groups are the only thing supported, but for now it's simpler.