Add spellchecking with crate-ci/typos#3166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3166 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18427 18458 +31
Branches 1215 1215
===============================================
+ Hits 18427 18458 +31
🚀 New features to boost your workflow:
|
| ``b"xn--caf-dma.com"``. | ||
|
|
||
| """ | ||
| ``b"xn--caf-dma.com"``.""" # spellchecker:disable-line |
There was a problem hiding this comment.
xn--caf is both in extend-identifiers in pyproject.toml and has spellchecker:disable-line?
There was a problem hiding this comment.
For some reason extend-identifiers does does not work as I intended and continues to try replacing it, so I added spellchecker:disable-line there to solve the issue. If there would be a way to get extend-identifiers to do ignore that one like I intended, that would be a better solution.
There was a problem hiding this comment.
in that case we should at least remove the non-functioning line in extend-identifiers, unless you wanna report it upstream.
|
with PARMETER->PARAMETER this needs a newsfragment |
In this pull request, we add https://github.com/crate-ci/typos as a pre-commit spellchecker and fix various typos found with this particular spellchecker.
They claim to have more features than codespell, but I don't really see a reason why we couldn't use both as long as they aren't fighting each other.
I learned about crate-ci/typos quite recently when looking through changes made to the mypy daemon as a part of mypy 1.14.0, so I'm not super familiar with how the configuration works, but I think it's at least mostly working as is. What I've tried to add as known "identifiers" with
-s in them don't seem to be functioning as I intended however.